Add support for using the VM across the RPC boundary. #7746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkonolige
approved these changes
Mar 26, 2021
Contributor
tkonolige
left a comment
tkonolige
left a comment
There was a problem hiding this comment.
Just a couple of small changes.
areusch
requested changes
Mar 26, 2021
adelbertc
approved these changes
Mar 26, 2021
areusch
requested changes
Mar 26, 2021
Contributor
areusch
left a comment
areusch
left a comment
There was a problem hiding this comment.
just a couple more things
Member
Author
|
The last commit resolves all the outstanding comments, we will wait to be on 3.7 to use type annotations and I added doc comments and clarifications. |
areusch
approved these changes
Mar 26, 2021
Member
|
please fix the linting error again. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* Get basic verison of VM RPC working * Test case passes * Clean up PR * Lint * Format * Address Andrew R and TK feedback * Add comment for Andrew * Address Zhi's comment * Format * Fix broken test
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* Get basic verison of VM RPC working * Test case passes * Clean up PR * Lint * Format * Address Andrew R and TK feedback * Add comment for Andrew * Address Zhi's comment * Format * Fix broken test
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* Get basic verison of VM RPC working * Test case passes * Clean up PR * Lint * Format * Address Andrew R and TK feedback * Add comment for Andrew * Address Zhi's comment * Format * Fix broken test
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
* Get basic verison of VM RPC working * Test case passes * Clean up PR * Lint * Format * Address Andrew R and TK feedback * Add comment for Andrew * Address Zhi's comment * Format * Fix broken test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor some of the internals of VM in order to enable use across the RPC boundary. I need to remove the use of the
libfield to instead use the imports completely still.cc @zhiics @adelbertc @tmoreau89 @tkonolige @jwfromm @michalpiszczek