[RPC][REFACTOR] Use PopenWorker to handle RPC Server. #7889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
force-pushed
the
popen
branch
3 times, most recently
from
7e27412 to
5d51829
Compare
Previously the rpc server relies multiprocessing to start a new process and does not work under jupyter. It also have a popen mode that does ensure the socket start listening before returning the port number. This PR switches the implementations use PopenWorker. The port number is returned after the socket get binded, which resolves some of the RPC flaky issues(need sleep to wait the server to start). It also makes the RPC server jupyter friendly.
junrushao
approved these changes
Apr 20, 2021
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 22, 2021
Previously the rpc server relies multiprocessing to start a new process and does not work under jupyter. It also have a popen mode that does ensure the socket start listening before returning the port number. This PR switches the implementations use PopenWorker. The port number is returned after the socket get binded, which resolves some of the RPC flaky issues(need sleep to wait the server to start). It also makes the RPC server jupyter friendly.
echuraev
pushed a commit
to echuraev/tvm
that referenced
this pull request
Apr 29, 2021
Previously the rpc server relies multiprocessing to start a new process and does not work under jupyter. It also have a popen mode that does ensure the socket start listening before returning the port number. This PR switches the implementations use PopenWorker. The port number is returned after the socket get binded, which resolves some of the RPC flaky issues(need sleep to wait the server to start). It also makes the RPC server jupyter friendly.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Previously the rpc server relies multiprocessing to start a new process and does not work under jupyter. It also have a popen mode that does ensure the socket start listening before returning the port number. This PR switches the implementations use PopenWorker. The port number is returned after the socket get binded, which resolves some of the RPC flaky issues(need sleep to wait the server to start). It also makes the RPC server jupyter friendly.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Previously the rpc server relies multiprocessing to start a new process and does not work under jupyter. It also have a popen mode that does ensure the socket start listening before returning the port number. This PR switches the implementations use PopenWorker. The port number is returned after the socket get binded, which resolves some of the RPC flaky issues(need sleep to wait the server to start). It also makes the RPC server jupyter friendly.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Previously the rpc server relies multiprocessing to start a new process and does not work under jupyter. It also have a popen mode that does ensure the socket start listening before returning the port number. This PR switches the implementations use PopenWorker. The port number is returned after the socket get binded, which resolves some of the RPC flaky issues(need sleep to wait the server to start). It also makes the RPC server jupyter friendly.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Previously the rpc server relies multiprocessing to start a new process and does not work under jupyter. It also have a popen mode that does ensure the socket start listening before returning the port number. This PR switches the implementations use PopenWorker. The port number is returned after the socket get binded, which resolves some of the RPC flaky issues(need sleep to wait the server to start). It also makes the RPC server jupyter friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the rpc server relies multiprocessing to start a new process and does not work under jupyter.
It also have a popen mode that does ensure the socket start listening before returning the port number.
This PR switches the implementations use PopenWorker. The port number is returned after the socket
get binded, which resolves some of the RPC flaky issues(need sleep to wait the server to start).
It also makes the RPC server jupyter friendly.