[ONNX] Support importing Conv with missing attributes #7899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@mbrookhart it looks like one of the onnx test nodes is constructed with a bad output shape. |
Contributor
Author
|
huh, this is an onnxruntime error... I can't seem to install the version of onnx runtime we're using in CI, it's not in pip... Will try to debug. |
Contributor
Author
|
I found the issue by going to onnxruntime 1.2.0. I missed a case where dilation was the the default value, so I dropped it by mistake. |
Contributor
|
Thanks @mbrookhart! This is now merged. |
echuraev
pushed a commit
to echuraev/tvm
that referenced
this pull request
Apr 29, 2021
* [ONNX] Support importing Conv with missing attributes * fix removal of attributes ONLY when they are default and for autopad * move comment to the right place
umangyadav
pushed a commit
to umangyadav/tvm
that referenced
this pull request
May 5, 2021
* [ONNX] Support importing Conv with missing attributes * fix removal of attributes ONLY when they are default and for autopad * move comment to the right place
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* [ONNX] Support importing Conv with missing attributes * fix removal of attributes ONLY when they are default and for autopad * move comment to the right place
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* [ONNX] Support importing Conv with missing attributes * fix removal of attributes ONLY when they are default and for autopad * move comment to the right place
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
* [ONNX] Support importing Conv with missing attributes * fix removal of attributes ONLY when they are default and for autopad * move comment to the right place
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
* [ONNX] Support importing Conv with missing attributes * fix removal of attributes ONLY when they are default and for autopad * move comment to the right place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.