[Frontend][Tensorflow] SelectV2 and BroadcastArgs op support for tf2 models #7901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
rohanmukh
reviewed
Apr 21, 2021
| out.appendleft(s1[s1_size - i]) | ||
| if s1_size < s0_size: | ||
| for i in range(s1_size + 1, s0_size + 1): | ||
| out.appendleft(s0[s0_size - i]) |
Contributor
There was a problem hiding this comment.
Is it better to use itertools.zip_longest() on the reversed array instead of running three separate loops? Might be helpful to have fill_values set at 1 to avoid handling None values.
Contributor
Author
There was a problem hiding this comment.
This will require atleast two list inversions (both the inputs as we have to iterate in reverse to verify broadcasting rules). Fill values will only make sense if I use a zip. It is only two loops (one of last two will fail) and merging them to one will give marginal optimization.
rohanmukh
reviewed
Apr 21, 2021
comaniac
requested changes
Apr 23, 2021
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
Please revert the change of updating submodules.
Also cc @yongwww @kevinthesun @zhiics
srinidhigoud
force-pushed
the
tf2_iod_support
branch
from
89ac729 to
013590d
Compare
srinidhigoud
force-pushed
the
tf2_iod_support
branch
from
013590d to
3df4763
Compare
Contributor
|
Thanks @srinidhigoud @rohanmukh |
echuraev
pushed a commit
to echuraev/tvm
that referenced
this pull request
Apr 29, 2021
umangyadav
pushed a commit
to umangyadav/tvm
that referenced
this pull request
May 5, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support in tf parser for new ops SelectV2 and BroadcastArgs introduced by tf2. This is focused on compiling and running the tf2 version of the object detection models such as faster rcnn model. Since both the inputs to BroadcastArgs were constant for every instance of the op in the model there was no need to write a relay op.