Always docker/build.sh with --no-cache. #8038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
leandron
reviewed
May 15, 2021
Contributor
leandron
left a comment
leandron
left a comment
There was a problem hiding this comment.
LGTM, just need to remove a change which I think doesn't belong to this PR.
| # As part of the build process, Zephyr needs to touch some symlinks in zephyr/misc/generated/syscalls_links (this path is relative to the | ||
| # build directory for a project). Mark the zephyr installation world-writable since this is a docker | ||
| # container | ||
| chmod -R o+w ${ZEPHYR_PROJECT_PATH} |
Contributor
Author
There was a problem hiding this comment.
ooops, looks like i forgot to checkout. thanks!
* Almost every docker container starts with apt-get install foo bar * This is inherently not cacheable, meanwhile the lack of --no-cache has bitten nearly everyone I've talked to who's tried to rebuild. * Adding now to address this repeated problem.
areusch
force-pushed
the
docker_build_no_cache
branch
from
0135357 to
29d8657
Compare
Contributor
|
@areusch feel free to merge it - I just didn't merge because CI was still pending, but the contents of this specific PR are not really tested in CI here, so feel free to merge when you're happy to do so. |
Contributor
|
Thanks @areusch! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
* Almost every docker container starts with apt-get install foo bar * This is inherently not cacheable, meanwhile the lack of --no-cache has bitten nearly everyone I've talked to who's tried to rebuild. * Adding now to address this repeated problem.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
* Almost every docker container starts with apt-get install foo bar * This is inherently not cacheable, meanwhile the lack of --no-cache has bitten nearly everyone I've talked to who's tried to rebuild. * Adding now to address this repeated problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has bitten nearly everyone I've talked to who's tried to rebuild.