[BYOC][Verilator] Skip mobilenet test if Verilator is not available #8094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandron
reviewed
May 20, 2021
Contributor
leandron
left a comment
leandron
left a comment
There was a problem hiding this comment.
Thanks @vegaluisjose, just a small note on the approach to skip the test.
leandron
approved these changes
May 20, 2021
Contributor
There was a problem hiding this comment.
LGTM - waiting CI, then feel free to merge it.
Thanks @vegaluisjose!
Contributor
|
Merged now. thanks @vegaluisjose @tmoreau89 ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8094) * skip mobilenet test when verilator is not available * add skipped to pytest * add pytest
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
…pache#8094) * skip mobilenet test when verilator is not available * add skipped to pytest * add pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leandron @tmoreau89