Pin black version #8139
Merged
Pin black version #8139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @areusch @tkonolige re: your work in updating the Docker images. The chosen pinned version comes from the version being currently used by Recently released version of |
leandron
approved these changes
May 26, 2021
areusch
requested changes
May 26, 2021
| RUN apt-get update && apt-get install -y doxygen graphviz | ||
|
|
||
| RUN pip3 install cpplint pylint==2.4.4 mypy black | ||
| RUN pip3 install cpplint pylint==2.4.4 mypy black==20.8b1 |
Contributor
There was a problem hiding this comment.
could you also add this in python/gen_requirements.py (the CONSTRAINTS global). i've been focused on CI work but will pick that up again soon.
Contributor
Author
There was a problem hiding this comment.
Done. Thank you for the review.
NicolaLancellotti
force-pushed
the
black/pin_version
branch
from
ed298d2 to
d6ed645
Compare
This commit pins the black version to provide stability. It is expected that the pinned version will be moved forward periodically. Change-Id: Ied866bff85a1a832959bc1d4673a7fdec68128a7
NicolaLancellotti
force-pushed
the
black/pin_version
branch
from
d6ed645 to
30a149a
Compare
areusch
approved these changes
May 28, 2021
Contributor
areusch
left a comment
areusch
left a comment
There was a problem hiding this comment.
thanks @NicolaLancellotti !
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
This commit pins the black version to provide stability. It is expected that the pinned version will be moved forward periodically. Change-Id: Ied866bff85a1a832959bc1d4673a7fdec68128a7
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
This commit pins the black version to provide stability. It is expected that the pinned version will be moved forward periodically. Change-Id: Ied866bff85a1a832959bc1d4673a7fdec68128a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr pins the black version to provide stability.
It is expected that the pinned version will be moved forward periodically.