[Vulkan][UnitTests] Compatibility fix for test_vulkan_unique() #8186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relay.unique return values changed in 6baccc1, updating vulkan unit tests to match.
Contributor
Author
|
Potential reviewers: @masahi as this touches the vulkan-specific tests. |
masahi
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return values for
relay.uniquewere changed in 6baccc1, updating vulkan unit tests to match. Longer-term, once the details for parametrized unit tests (#8010) are settled, I think this is a point in favor of parametrizing a test case over multiple targets, even if it is designed to trigger a bug that only exists in one.