-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Turn on Compute library testing in CI for AArch64 #8291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request turns on compute library testing in CI by 1. Handling import errors in Compute Library Integration. 2. Setting the configuration to the right path for ACL. This handles import errors for packages in Compute library integration. This pull request allows for the AArch64 CI to pick up native compute library testing and tests the operators being offloaded at runtime.
* Move to using pre-built ACL binaries for ci_arm * Fixup the path for installation to be /opt/acl as it originally was. * Fix up the issues with paths. Once this is done ci_arm will need to be rebuilt though will continue to work seamlessly.
lhutton1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to ignore small suggestion
cc @areusch @mbrookhart, I believe this change requires a container update?
| try: | ||
| import tvm.relay.testing.tf as tf_testing | ||
| except ImportError: | ||
| pytest.skip("Missing TF Support") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| pytest.skip("Missing TF Support") | |
| pytest.skip("Missing Tflite Support") |
|
I'm rebuilding CI containers this week, I'll include this in that. |
* Turn on Compute library testing in CI. This pull request turns on compute library testing in CI by 1. Handling import errors in Compute Library Integration. 2. Setting the configuration to the right path for ACL. This handles import errors for packages in Compute library integration. This pull request allows for the AArch64 CI to pick up native compute library testing and tests the operators being offloaded at runtime. * Fix typo * Fix up use of ubuntu_install_arm_compute_lib.sh in Dockerfile.ci_arm * Move to using pre-built ACL binaries for ci_arm * Fixup the path for installation to be /opt/acl as it originally was. * Fix up the issues with paths. Once this is done ci_arm will need to be rebuilt though will continue to work seamlessly.
* Turn on Compute library testing in CI. This pull request turns on compute library testing in CI by 1. Handling import errors in Compute Library Integration. 2. Setting the configuration to the right path for ACL. This handles import errors for packages in Compute library integration. This pull request allows for the AArch64 CI to pick up native compute library testing and tests the operators being offloaded at runtime. * Fix typo * Fix up use of ubuntu_install_arm_compute_lib.sh in Dockerfile.ci_arm * Move to using pre-built ACL binaries for ci_arm * Fixup the path for installation to be /opt/acl as it originally was. * Fix up the issues with paths. Once this is done ci_arm will need to be rebuilt though will continue to work seamlessly.
This pull request turns on compute library testing in CI by
This pull request allows for the AArch64 CI to pick up native
compute library testing and tests the operators being offloaded at
runtime.
@mbaret @d-smirnov @lhutton1 - could I get a review please ?