Skip to content

Conversation

@u99127
Copy link

@u99127 u99127 commented Jun 21, 2021

This pull request turns on compute library testing in CI by

  1. Handling import errors in Compute Library Integration.
  2. Setting the configuration to the right path for ACL.

This pull request allows for the AArch64 CI to pick up native
compute library testing and tests the operators being offloaded at
runtime.

@mbaret @d-smirnov @lhutton1 - could I get a review please ?

Ramana Radhakrishnan added 3 commits June 21, 2021 11:10
This pull request turns on compute library testing in CI by

1. Handling import errors in Compute Library Integration.
2. Setting the configuration to the right path for ACL.

This handles import errors for packages in Compute library integration.
This pull request allows for the AArch64 CI to pick up native
compute library testing and tests the operators being offloaded at
runtime.
* Move to using pre-built ACL binaries for ci_arm
* Fixup the path for installation to be /opt/acl as it originally was.
* Fix up the issues with paths.

Once this is done ci_arm will need to be rebuilt though will continue
to work seamlessly.
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to ignore small suggestion

cc @areusch @mbrookhart, I believe this change requires a container update?

try:
import tvm.relay.testing.tf as tf_testing
except ImportError:
pytest.skip("Missing TF Support")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pytest.skip("Missing TF Support")
pytest.skip("Missing Tflite Support")

@mbrookhart
Copy link
Contributor

I'm rebuilding CI containers this week, I'll include this in that.

@mbrookhart mbrookhart merged commit 5c2836c into apache:main Jun 22, 2021
@mbrookhart
Copy link
Contributor

Thanks @u99127 @lhutton1

ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* Turn on Compute library testing in CI.

This pull request turns on compute library testing in CI by

1. Handling import errors in Compute Library Integration.
2. Setting the configuration to the right path for ACL.

This handles import errors for packages in Compute library integration.
This pull request allows for the AArch64 CI to pick up native
compute library testing and tests the operators being offloaded at
runtime.

* Fix typo

* Fix up use of ubuntu_install_arm_compute_lib.sh in Dockerfile.ci_arm

* Move to using pre-built ACL binaries for ci_arm
* Fixup the path for installation to be /opt/acl as it originally was.
* Fix up the issues with paths.

Once this is done ci_arm will need to be rebuilt though will continue
to work seamlessly.
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
* Turn on Compute library testing in CI.

This pull request turns on compute library testing in CI by

1. Handling import errors in Compute Library Integration.
2. Setting the configuration to the right path for ACL.

This handles import errors for packages in Compute library integration.
This pull request allows for the AArch64 CI to pick up native
compute library testing and tests the operators being offloaded at
runtime.

* Fix typo

* Fix up use of ubuntu_install_arm_compute_lib.sh in Dockerfile.ci_arm

* Move to using pre-built ACL binaries for ci_arm
* Fixup the path for installation to be /opt/acl as it originally was.
* Fix up the issues with paths.

Once this is done ci_arm will need to be rebuilt though will continue
to work seamlessly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants