[Docker] Fix ordering of tf and tflite installs in ci_qemu #8315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Lolz, I just opened #8314. I'll close that one in favor of this one. |
Contributor
Author
|
Hehe. I was just about to close this one when I saw your comment. It would have been the git equivalent of getting to a stop sign at exactly the same time. |
mbrookhart
approved these changes
Jun 23, 2021
26 tasks
Contributor
|
@Lunderberg You hit a timeout in CI, can you re-launch? |
Lunderberg
force-pushed
the
ci_qemu_tflite_order
branch
from
bb2333e to
dd0e0f0
Compare
Contributor
Author
|
And re-launched. |
leandron
reviewed
Jun 24, 2021
Contributor
leandron
left a comment
leandron
left a comment
There was a problem hiding this comment.
Now you happened to find a flaky test :), so CI needs re-triggering yet again.
I also suggest you report the flaky test as an issue, so that it can be dealt with.
Similar to apache#8312, the recently merged apache#8306 required tflite to be installed after tf. However, apache#8306 did not correct the ordering in the dockerfiles. After this and apache#8312, all dockerfiles should be up to date with the correct ordering.
Lunderberg
force-pushed
the
ci_qemu_tflite_order
branch
from
dd0e0f0 to
1cb28e9
Compare
Contributor
Author
|
Bumped the CI again. It looks like there is a tracking issue #8140 for this particular flaky test case, though there isn't a resolution yet. |
Contributor
|
Thanks @Lunderberg @leandron |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
Similar to apache#8312, the recently merged apache#8306 required tflite to be installed after tf. However, apache#8306 did not correct the ordering in the dockerfiles. After this and apache#8312, all dockerfiles should be up to date with the correct ordering. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
Similar to apache#8312, the recently merged apache#8306 required tflite to be installed after tf. However, apache#8306 did not correct the ordering in the dockerfiles. After this and apache#8312, all dockerfiles should be up to date with the correct ordering. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #8312, the recently merged #8306 required tflite to be installed after tf. However, #8306 did not correct the ordering in the dockerfiles. After this and #8312, all dockerfiles should be up to date with the correct ordering.