[Onnx] Support Bidirectional RNNs #8337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwfromm
approved these changes
Jun 25, 2021
Contributor
jwfromm
left a comment
jwfromm
left a comment
There was a problem hiding this comment.
Very nice implementation, excellent PR @AndrewZhaoLuo!
AndrewZhaoLuo
force-pushed
the
andrewluo-onnx-add-bidirectional-lstm
branch
from
f1ce2bb to
804bc7b
Compare
Contributor
|
Thanks @AndrewZhaoLuo @jwfromm |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* modify lstm to be easily bidirectional * make it obvious some matriciies are packed via prime notation * fix var name * more var names * add op split * keyword arg names * missing implicit cls arg * deal with extra dimensions * last of the fixes * refactor rnn tests to support directions * bidirectional tests * test forward results * go backwards * more fixes * reverse tokens on reverse pass * parameterized directions * double up activations in bidirect * slow attribute forgetting * lstm interface is v. confus * test forward complete * add GRU outline * revisiion2 * why was tehre a not * gru tests * missing bounds, copy pasta! * add comment * ensure all args fp
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
* modify lstm to be easily bidirectional * make it obvious some matriciies are packed via prime notation * fix var name * more var names * add op split * keyword arg names * missing implicit cls arg * deal with extra dimensions * last of the fixes * refactor rnn tests to support directions * bidirectional tests * test forward results * go backwards * more fixes * reverse tokens on reverse pass * parameterized directions * double up activations in bidirect * slow attribute forgetting * lstm interface is v. confus * test forward complete * add GRU outline * revisiion2 * why was tehre a not * gru tests * missing bounds, copy pasta! * add comment * ensure all args fp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSTMs and GRUs now support the common bidirectional flag.
cc @mbrookhart