Relay to onnx conversion #8362
Closed
Relay to onnx conversion #8362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added support for Sigmoid op * added unit test
* added support for Copy op * added unit test
* added missing ceil_mode in average pool and max pool conversion
* added support for Round op * added unit test
* added support for Cast op * added unit test
* fixed formatting
* Added support for conv2d transpose operator * Added unit test case. Unit test is similar to the conv2d unit test.
* Fixed issue in Pad conversion * Updated unit test * Known issue: Relay pad defn is missing pad_value arg
* Changed pad_value to input instead of attrs * See PR: #7860 * Fixed some formatting errors
Could you please fix the title to say this adds support for the above mentioned ONNX operators. The ONNX frontend lowers to Relay , not the other way around .. :) Could you also have a separate pull request for fixing issues vs new features and could you explain what the fixes are doing and if there are tests that cover these fixes ? |
Contributor
Author
|
Okay, will make those changes and resubmit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.