Skip to content

Conversation

@u99127
Copy link

@u99127 u99127 commented Jul 2, 2021

Add missing Requires GPU on this test as this fails when topi tests are run on CPUs without GPUs.

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandron
Copy link
Contributor

leandron commented Jul 2, 2021

cc @Lunderberg

@leandron leandron merged commit 354d996 into apache:main Jul 2, 2021
@leandron
Copy link
Contributor

leandron commented Jul 2, 2021

This is merged now, thanks @u99127!

@Lunderberg
Copy link
Contributor

Thank you @u99127 for finding this. In principle, the parametrized target value is supposed to apply the requires_gpu annotation for any gpu targets, but it looks like the use of pytest.mark.parametrize skipped past that feature. I'll see what I can do to make it more robust against such issues in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants