[BUILD] Try to fix ONNX CPU tests being disabled #8390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkonolige
approved these changes
Jul 6, 2021
Contributor
tkonolige
left a comment
tkonolige
left a comment
There was a problem hiding this comment.
Thanks @electriclilies! I'm pretty sure this was my fault.
Contributor
|
@electriclilies It looks like the CPU image doesn't have the necessary depencencies for ONNX. Could you make a PR to run install onnx in the CPU docker file? |
electriclilies
requested review from
a team,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
electriclilies
force-pushed
the
onnx_cpu_tests
branch
2 times, most recently
from
80f7d82 to
be5502e
Compare
electriclilies
force-pushed
the
onnx_cpu_tests
branch
from
be5502e to
e2c40e6
Compare
Contributor
|
what's the status on this one? |
Contributor
Author
|
@areusch I think that @mbrookhart fixed this through other means and we just didn't close this PR. Thanks for following up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbrookhart Added a line that should run the tests on CPU-- hopefully this fixes the problem