Prepare the topi tests for AArch64 CI. #8409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u99127
force-pushed
the
add-topi-tests-aarch64
branch
from
51ba6d6 to
7f0272d
Compare
jcf94
reviewed
Jul 8, 2021
Comment on lines
80
to
78
| for device in ["llvm"]: | ||
| check_device(device) | ||
| for target, dev in tvm.testing.enabled_targets(): | ||
| check_device(target, dev) |
Contributor
There was a problem hiding this comment.
Seems the schedules for sparse ops are not ready for GPU? I see the CI failed in cases like this.
We can add a TODO notes here.
Author
There was a problem hiding this comment.
Yes agreed. there's a few of them like that which needs to be fixed. WIP.
added 4 commits
August 3, 2021 21:52
This pull request cleans up the TOPI testuite for use on the AArch64 CI target by doing the following: - Introducing a script to run the tests on AArch64 with a suitable invocation of the llvm target string by setting the TVM_TEST_TARGETS environment variable. - Cleaning up the use of hard coded targets and moving the testsuite to testing more sensibly with the use of tvm.testing.enabled_targets. - Cleanup the use of tvm.target.create. - The above allows for the use of tests reasonably with the topi tests and cleans up what is needed from the testsuite. Putting this up for a test run on ci_gpu and ci_cpu to see the effects of moving TOPI test runs to AArch64 CPU before firing up the Jenkins changes. The motivation was from apache#8361 to pipeclean and add this support.
Change-Id: I70537a20bc683c490ef3a504a14136e7b0a1456d
u99127
force-pushed
the
add-topi-tests-aarch64
branch
from
7f0272d to
b91ceb6
Compare
u99127
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
areusch
requested changes
Sep 7, 2021
|
|
||
| for target, dev in tvm.testing.enabled_targets(): | ||
| check_device(target, dev) | ||
| for device in ["llvm", "cuda"]: |
Contributor
There was a problem hiding this comment.
should these become @tvm.testing.requires_?
| # for device in ['llvm -mcpu=skylake-avx512']: | ||
| for device in ["llvm"]: | ||
| check_device(device) | ||
| for target, dev in tvm.testing.enabled_targets(): |
Contributor
There was a problem hiding this comment.
same question--possible to use tvm.testing.parametrize_targets ?
|
|
||
| for device in ["llvm"]: | ||
| check_device(device) | ||
| # Unable to use the following idiom and thus restrict to llvm only. |
|
|
||
| for device in ["llvm"]: | ||
| check_device(device) | ||
| # This test is not yet ready to use the idiom , |
Contributor
There was a problem hiding this comment.
could you say what's missing in the comment?
| tvm.testing.assert_allclose(Y_tvm.numpy(), Y_np.astype("float32"), atol=1e-4, rtol=1e-4) | ||
|
|
||
| check_device("llvm") | ||
| # Unable to use the idiom below as the test isn't suitable for non llvm targets. |
Member
|
@u99127 Can you update or close this PR? |
jroesch
added
the
needs-triage
Author
|
Abandoned in favour of other changes from @Mousius and others fixing this for AArch64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request cleans up the TOPI testuite for use on the AArch64
CI target by doing the following:
Introducing a script to run the tests on AArch64 with a suitable
invocation of the llvm target string by setting the TVM_TEST_TARGETS
environment variable.
Cleaning up the use of hard coded targets and moving the testsuite
to testing more sensibly with the use of tvm.testing.enabled_targets.
Cleanup the use of tvm.target.create.
Putting this up for a test run on ci_gpu and ci_cpu to see the effects
of moving TOPI test runs to AArch64 CPU before firing up the Jenkins
changes.
The motivation was from #8361 to pipeclean and add this support.