[Topi][UnitTests] Parameterize conv2d and depthwise_conv2d tests #8433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tmoreau89 This refactoring of tests is to make it easier to extend support for float16, and to make sure that the existing features are as tested as possible. In the next day or two, I'll be sending a separate PR based on this one that adds the float16 parametrization to these tests. |
…ed tests. - Better error messages, displays which workloads/targets failed and why. - Fixed bug in topi.nn.conv2d._get_workload exposed by the parametrized tests. Incorrect padding if the "SAME" parameter is used with dilation>1. - Fixed bug in tvm.topi.x86.group_conv2d._get_default_config, missing dilation parameter in call to _get_conv2d_workload.
…d.py In preparation for parametrizing to test on float16 as well. - Single test_conv2d test with parameters for layout/input sizes. - Extended the support for NCHWc layouts, so that they could be included in the parametrization. (Implemented topi.testing.depthwise_conv2d_python_nchwc and topi.nn.scale_shift_nchwc, added layout argument to topi.nn.depthwise_conv2d._get_workload).
Lunderberg
force-pushed
the
topi_conv2d_parametrize
branch
from
b3b040e to
7d9c3ed
Compare
masahi
approved these changes
Jul 22, 2021
Member
masahi
left a comment
masahi
left a comment
There was a problem hiding this comment.
Looks very clean, thanks @Lunderberg
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…che#8433) * [UnitTests][Topi] Updated test_topi_conv2d_nchw.py to have parametrized tests. - Better error messages, displays which workloads/targets failed and why. - Fixed bug in topi.nn.conv2d._get_workload exposed by the parametrized tests. Incorrect padding if the "SAME" parameter is used with dilation>1. - Fixed bug in tvm.topi.x86.group_conv2d._get_default_config, missing dilation parameter in call to _get_conv2d_workload. * [UnitTests][Topi] Parametrized the tests in test_topi_depthwise_conv2d.py In preparation for parametrizing to test on float16 as well. - Single test_conv2d test with parameters for layout/input sizes. - Extended the support for NCHWc layouts, so that they could be included in the parametrization. (Implemented topi.testing.depthwise_conv2d_python_nchwc and topi.nn.scale_shift_nchwc, added layout argument to topi.nn.depthwise_conv2d._get_workload). Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…che#8433) * [UnitTests][Topi] Updated test_topi_conv2d_nchw.py to have parametrized tests. - Better error messages, displays which workloads/targets failed and why. - Fixed bug in topi.nn.conv2d._get_workload exposed by the parametrized tests. Incorrect padding if the "SAME" parameter is used with dilation>1. - Fixed bug in tvm.topi.x86.group_conv2d._get_default_config, missing dilation parameter in call to _get_conv2d_workload. * [UnitTests][Topi] Parametrized the tests in test_topi_depthwise_conv2d.py In preparation for parametrizing to test on float16 as well. - Single test_conv2d test with parameters for layout/input sizes. - Extended the support for NCHWc layouts, so that they could be included in the parametrization. (Implemented topi.testing.depthwise_conv2d_python_nchwc and topi.nn.scale_shift_nchwc, added layout argument to topi.nn.depthwise_conv2d._get_workload). Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along similar lines to #8336, parametrizing and cleaning up unit tests for conv2d and depthwise_conv2d unit tests.
[UnitTests][Topi] Updated test_topi_conv2d_nchw.py to have parametrized tests.
Better error messages, displays which workloads/targets failed and why.
Fixed bug in topi.nn.conv2d._get_workload exposed by the parametrized tests. Incorrect padding if the "SAME" parameter is used with dilation>1.
[UnitTests][Topi] Parametrized the tests in test_topi_depthwise_conv2d.py
In preparation for parametrizing to test on float16 as well.
Single test_conv2d test with parameters for layout/input sizes.
Extended the support for NCHWc layouts, so that they could be included in the parametrization. (Implemented topi.testing.depthwise_conv2d_python_nchwc and topi.nn.scale_shift_nchwc, added layout argument to topi.nn.depthwise_conv2d._get_workload).