[Bugfix] Preserve IRModule type definition and imports in NameMangleExtFuncs #8523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxy844288792
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
comaniac
requested changes
Jul 21, 2021
comaniac
changed the title
Contributor
|
cc @manupa-arm |
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
manupak
approved these changes
Jul 23, 2021
Contributor
manupak
left a comment
manupak
left a comment
There was a problem hiding this comment.
Thanks for the fix! LGTM!
comaniac
reviewed
Jul 23, 2021
Contributor
|
Thanks @zxy844288792 @manupa-arm |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…xtFuncs (apache#8523) * bug fix and add tensorarray with partition pass test case * change test function location and address comments * Update tests/python/relay/test_pass_partition_graph.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * trigger CI Co-authored-by: Cody Yu <comaniac0422@gmail.com>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…xtFuncs (apache#8523) * bug fix and add tensorarray with partition pass test case * change test function location and address comments * Update tests/python/relay/test_pass_partition_graph.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * trigger CI Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling graph_partition pass on tensoraay ops, it fails with error
Check failed: (it != type_definitions.end()) is false: There is no definition of static_tensor_float32_any_2_3_tThis is introduced by #8014.This fix imports type definations from old module when craeting a new module in NameMangleExtFuncs.
cc @comaniac