Fix storage_access not visiting else branch #8525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
requested review from
ZihengJiang,
areusch,
comaniac,
jroesch,
junrushao,
kparzysz-quic,
merrymercy,
tqchen,
vinx13 and
yzhliu
as code owners
masahi
removed request for
ZihengJiang,
areusch,
comaniac,
jroesch,
junrushao,
kparzysz-quic,
merrymercy,
tqchen,
vinx13 and
yzhliu
vinx13
approved these changes
Jul 22, 2021
tqchen
approved these changes
Jul 22, 2021
masahi
force-pushed
the
fix-storage-access-else-branch
branch
8 times, most recently
from
09e0dc6 to
11df067
Compare
masahi
force-pushed
the
fix-storage-access-else-branch
branch
2 times, most recently
from
651f71f to
9937b99
Compare
jcf94
approved these changes
Jul 29, 2021
masahi
force-pushed
the
fix-storage-access-else-branch
branch
from
9937b99 to
751d7c8
Compare
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* Fix storage_access not visiting else branch * fix conflict with apache#8516 in the test * update thread sync test following apache#8516 update
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Fix storage_access not visiting else branch * fix conflict with apache#8516 in the test * update thread sync test following apache#8516 update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7724
@tqchen @pratikfegade