Skip to content

Conversation

@YuchenJin
Copy link
Contributor

This PR unifies the common optimization pass prefix shared between vm and graph executor into a single API.

@YuchenJin
Copy link
Contributor Author

@jroesch could you take a look?

It would be great if we can move RunDeviceAnnotationPass to Relay pass infra and the relay::transform namespace, the code would be cleaner and more passes can be packed into this prefix.

Copy link
Contributor

@jcf94 jcf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine to me.

Copy link
Contributor

@jcf94 jcf94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me.

@tqchen tqchen merged commit 28de742 into apache:main Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants