[Onnx][UnitTests] Excluded additional onnx tests #8574
Conversation
Lunderberg
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
|
@mbrookhart Can you review this, especially the addition of the cuda-specific excluded tests? |
mbrookhart
left a comment
mbrookhart
left a comment
There was a problem hiding this comment.
One confusion on parametarization, otherwise LGTM
| pytest.skip() | ||
| break | ||
| @pytest.mark.parametrize("onnx_test", onnx_test_folders) | ||
| def test_onnx_nodes(target, dev, onnx_test): |
There was a problem hiding this comment.
I'm not seeing how target and dev get into the test?
There was a problem hiding this comment.
This was a feature that I added in #8010 , where any unit test or fixture that accepts a target or dev argument is parametrized over all targets in tvm.testing.enabled_targets. Basically, the same as the explicit pytest.mark.parametrize that was there previously, or the tvm.testing.parametrize_targets, but without needing each function to reproduce the same boilerplate. The target parametrize is defined in tvm.testing._auto_parametrize_target, and the dev fixture based on it is in the conftest.py.
- The onnx tests `test_basic_convinteger`, `test_convinteger_with_padding`, `test_range_float_type_positive_delta_expanded`, and `test_range_int32_type_positive_delta_expanded` don't run correctly on CUDA targets, so they are added to the exclusion. - Parametrized over the relative directory name, rather than the full directory name. This improves readability of the pytest output, and keeps the same parametrized test name across different python version. - Changed the target-specific skips to check the target kind, rather than the full target string.
|
Closing, this clean-up will be done along-side #8542, which was based on this. |
2 participants
The onnx tests
test_basic_convinteger,test_convinteger_with_padding,test_range_float_type_positive_delta_expanded, andtest_range_int32_type_positive_delta_expandeddon't run correctly on CUDA targets, so they are added to the exclusion.Parametrized over the relative directory name, rather than the full directory name. This improves readability of the pytest output, and keeps the same parametrized test name across different python version.
Changed the target-specific skips to check the target kind, rather than the full target string.