[Vulkan] Prioritize discrete GPUs as device_id=0. #8588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added device_type to the device-queried information. - Sort the vulkan devices by the device_type. Priority is discrete > integrated > virtual > cpu > other.
Lunderberg
requested review from
ZihengJiang,
areusch,
junrushao,
kazum,
kparzysz-quic,
liangfu,
masahi,
tmoreau89,
tqchen and
vinx13
as code owners
Contributor
Author
masahi
approved these changes
Jul 30, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
- Added device_type to the device-queried information. - Sort the vulkan devices by the device_type. Priority is discrete > integrated > virtual > cpu > other. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
- Added device_type to the device-queried information. - Sort the vulkan devices by the device_type. Priority is discrete > integrated > virtual > cpu > other. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously caused some issues in performance comparison between cuda/vulkan, as
device_id=0referred to different physical hardware.Added device_type to the device-queried information.
Sort the vulkan devices by the device_type. Priority is discrete > integrated > virtual > cpu > other