[Refactor] Avoid Override Generic Op Strategy in "hls.py" #8614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnson9009
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
jroesch,
junrushao,
jwfromm,
mbrookhart,
slyubomirsky,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Contributor
Author
|
Below two CI test cases failed, the root cause are all CUDA hasn't implemented and register "conv2d_NCHWc_strategy", so these test cases are testing wrong target. Before this PR, the default "conv2d_NCHWc_strategy" will use "hls.py", in another words, CUDA conv2d_NCHWc_strategy use that of "hls.py" implicitly, so it will not report the error. 1. tests/python/relay/test_any.py::test_any_conv2d_NCHWc
2. tests/python/relay/test_pass_alter_op_layout.py::test_alter_layout_strided_sliceAll of these 2 test cases are decorated by "@tvm.testing.uses_gpu", the 1st one is decorated by PR #6598, the 2nd is decorated by PR #6331. @zhiics, @comaniac, @tkonolige, @tqchen, please help to see how should we change these test cases. Thanks. |
Johnson9009
requested review from
areusch,
comaniac,
merrymercy and
tqchen
as code owners
comaniac
approved these changes
Aug 3, 2021
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix.
Contributor
|
Thanks @Johnson9009 |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* [Refactor] Avoid Override Generic Op Strategy in "hls.py" * Fix The Broken CI Test Cases
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [Refactor] Avoid Override Generic Op Strategy in "hls.py" * Fix The Broken CI Test Cases
yuanzhaoti
pushed a commit
to TexasInstruments/tvm
that referenced
this pull request
Jun 24, 2022
* [Refactor] Avoid Override Generic Op Strategy in "hls.py" * Fix The Broken CI Test Cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very obvious issue, now "hls.py" directly call decorator "override_native_generic_func" to operator "conv2d", "conv2d_NCHWc", it should call decorator "conv2d_strategy" like
conv2d_strategy.register("hls").If new target is added, and there isn't define the new target specific "conv2d" op strategy, then the strategy will use that of "hls.py", this is not expected, it should use that of "generic.py".