[Frontend][ONNX] Add onnx support for LessOrEqual, GreaterOrEqual
#8626
Conversation
SamKG
requested review from
Huyuwei,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
merrymercy,
siju-samuel,
srkreddy1238,
tqchen and
yzhliu
as code owners
SamKG
force-pushed
the
main
branch
2 times, most recently
from
6bd58d3 to
4c06a07
Compare
thanks! |
SamKG
force-pushed
the
main
branch
2 times, most recently
from
db2af02 to
e09525b
Compare
|
Could a maintainer please re-run the workflow? I fixed a small typo in the commit |
AndrewZhaoLuo
left a comment
AndrewZhaoLuo
left a comment
There was a problem hiding this comment.
LGTM, btw if you need to jostle CI you can just git commit -m 'jostle ci' --allow-empty and push.
| "Exp": Renamer("exp"), | ||
| "Greater": Greater.get_converter(opset), | ||
| "Less": Less.get_converter(opset), | ||
| "LessOrEqual": LessOrEqual.get_converter(opset), |
There was a problem hiding this comment.
Can you just use Renamer, you are just forwarding the inputs in the converter?
| verify_binary_ops("Sum", x, z) | ||
| verify_binary_ops("Greater", x, y, "bool") | ||
| verify_binary_ops("Greater", x, z, "bool") | ||
| verify_binary_ops("GreaterOrEqual", x, y, "bool") |
There was a problem hiding this comment.
Can you uncomment the appropriate tests in unsupported_onnx_tests in this file?
|
@SamKG do you plan to try to get this merged? |
Hi Andrew, |
|
@SamKG do you mind if I open up an identical PR and try to merge that? Might need this in soon |
|
Go for it!
…On Mon, Sep 20, 2021, 4:39 PM AndrewZhaoLuo ***@***.***> wrote:
@SamKG <https://github.com/SamKG> do you mind if I open up an identical
PR and try to merge that? Might need this in soon
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8626 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADVAILYWYSIGH37GTHZDQKTUC6LZRANCNFSM5BNX456A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Closed as #9066 handles this ( thanks @AndrewZhaoLuo ) |
3 participants
This adds support for
LessOrEqual(<=) andGreaterOrEqual(>=) ops for ONNX frontend, as introduced in opset 12.