[AMP] Disallow fp16 conversion for arange op #8644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
comaniac
approved these changes
Aug 4, 2021
Contributor
comaniac
left a comment
comaniac
left a comment
There was a problem hiding this comment.
LGTM, although this does scarify GPU performance as you mentioned in the issue. Maybe we could rethink the way specifying whether an op can be casted or not. For example, we could have target-specific lists that can be used when running this pass with a target.
Contributor
|
LGTM, I would add a comment explaining why it's a red listed operation (e.g. end is a large number). |
AndrewZhaoLuo
approved these changes
Aug 4, 2021
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Aug 11, 2021
* [AMP] Do not allow fp16 cast on arange inputs * add test * Add comment explaining the issue with fp16 "end"
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* [AMP] Do not allow fp16 cast on arange inputs * add test * Add comment explaining the issue with fp16 "end"
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [AMP] Do not allow fp16 cast on arange inputs * add test * Add comment explaining the issue with fp16 "end"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now running the fp16 conversion pass on arange op results in a type error fp16 vs fp32, since we need to update
dtypeattributes of arangetvm/include/tvm/relay/attrs/transform.h
Line 197 in 1fac10b
We could fix the type error that way and support fp16 arguments to arange, but that would cause a problem when
endargument is a large number which happens to be fp32. So we should disallow fp16 conversion for arange. Since the inputs to arange are scalars, cast overhead is negligible.@AndrewZhaoLuo