[Target] Several minor corrections to the device property query #8651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass parameters through TVMRetValue as std::string instead of runtime::String - Remove escaping of spaces inside quotes for target attributes. Updated unit test to verify round-trip behavior. - Added missing "device_type" query for Vulkan.
Lunderberg
requested review from
ZihengJiang,
areusch,
comaniac,
jroesch,
junrushao,
kazum,
kparzysz-quic,
liangfu,
masahi,
merrymercy,
tmoreau89,
tqchen,
vinx13 and
yzhliu
as code owners
Contributor
Author
masahi
approved these changes
Aug 4, 2021
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Aug 11, 2021
…he#8651) - Pass parameters through TVMRetValue as std::string instead of runtime::String - Remove escaping of spaces inside quotes for target attributes. Updated unit test to verify round-trip behavior. - Added missing "device_type" query for Vulkan. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…he#8651) - Pass parameters through TVMRetValue as std::string instead of runtime::String - Remove escaping of spaces inside quotes for target attributes. Updated unit test to verify round-trip behavior. - Added missing "device_type" query for Vulkan. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…he#8651) - Pass parameters through TVMRetValue as std::string instead of runtime::String - Remove escaping of spaces inside quotes for target attributes. Updated unit test to verify round-trip behavior. - Added missing "device_type" query for Vulkan. Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass parameters through TVMRetValue as std::string instead of runtime::String
Remove escaping of spaces inside quotes for target attributes. Updated unit test to verify round-trip behavior.
Added missing "device_type" query for Vulkan.