[TEST] Refactor RPC test to isolate runs into a sub-function #8656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We kill the rpc server in the del function. When a server co-exist with remote resources in the same function scope, the destruction order is not determined. This can cause server to be destructed before the actual remote array. As a side effect, it can cause sometime test to timeout due to waiting on the socket.
tqchen
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy and
yzhliu
as code owners
junrushao
approved these changes
Aug 4, 2021
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
This theory definitely makes sense to me :-)
Contributor
|
this makes sense to me, but even better would be to create either a test fixture or context manager to wrap the server. then we can reason even better about when it should be destroyed, particularly with xdist. |
areusch
approved these changes
Aug 5, 2021
This was referenced Aug 5, 2021
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Aug 11, 2021
…8656) We kill the rpc server in the del function. When a server co-exist with remote resources in the same function scope, the destruction order is not determined. This can cause server to be destructed before the actual remote array. As a side effect, it can cause sometime test to timeout due to waiting on the socket.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…8656) We kill the rpc server in the del function. When a server co-exist with remote resources in the same function scope, the destruction order is not determined. This can cause server to be destructed before the actual remote array. As a side effect, it can cause sometime test to timeout due to waiting on the socket.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…8656) We kill the rpc server in the del function. When a server co-exist with remote resources in the same function scope, the destruction order is not determined. This can cause server to be destructed before the actual remote array. As a side effect, it can cause sometime test to timeout due to waiting on the socket.
apivovarov
pushed a commit
to apivovarov/tvm
that referenced
this pull request
May 8, 2022
…8656) We kill the rpc server in the del function. When a server co-exist with remote resources in the same function scope, the destruction order is not determined. This can cause server to be destructed before the actual remote array. As a side effect, it can cause sometime test to timeout due to waiting on the socket.
apivovarov
added a commit
to neo-ai/tvm
that referenced
this pull request
May 8, 2022
* [Jenkins] Use 8 and 16 jobs to build for GPU and CPU * [TEST] Refactor RPC test to isolate runs into a sub-function (apache#8656) We kill the rpc server in the del function. When a server co-exist with remote resources in the same function scope, the destruction order is not determined. This can cause server to be destructed before the actual remote array. As a side effect, it can cause sometime test to timeout due to waiting on the socket. Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We kill the rpc server in the del function. When a server
co-exist with remote resources in the same function scope,
the destruction order is not determined.
This can cause server to be destructed before the actual remote array.
As a side effect, it can cause sometime test to timeout due to
waiting on the socket.