[Bugfix][Target] Correct passing of target-queried bool/int parameters #8660
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
requested review from
ZihengJiang,
junrushao,
kparzysz-quic,
masahi,
tqchen and
vinx13
as code owners
junrushao
approved these changes
Aug 4, 2021
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Thanks for fixing this and thanks Masa for pointing out! I didn’t notice the order issue before :-)
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Aug 11, 2021
apache#8660) Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
apache#8660) Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
apache#8660) Co-authored-by: Eric Lunderberg <elunderberg@octoml.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for copy-paste error in #8602. Verified that this runs vulkan unit tests locally. @masahi, this should resolve the bug that you pointed out.