fixing build for Android RPC app #8719
Conversation
islavutin
requested review from
comaniac,
jroesch,
junrushao,
tqchen,
yzhliu and
zhiics
as code owners
| $(ROOT_PATH)/3rdparty/dlpack/include \ | ||
| $(ROOT_PATH)/3rdparty/dmlc-core/include | ||
| $(ROOT_PATH)/3rdparty/dmlc-core/include \ | ||
| $(ROOT_PATH)/3rdparty/compiler-rt |
There was a problem hiding this comment.
compiler-rt should be directly included using relative path, @islavutin can you point out the file that did not do that?
There was a problem hiding this comment.
Sorry @tqchen, could you expand on what you meant here?
There was a problem hiding this comment.
I meant that 3rdparty/compiler-rt does not need to be part of include path, because we suppose to include the files in it via relative ones, e.g. https://github.com/apache/tvm/blob/main/src/runtime/contrib/random/mt_random_engine.cc#L32
There was a problem hiding this comment.
so a fix should be change other include of the compiler rt file to relative include. We did not intend to use that particular file as a public header
There was a problem hiding this comment.
Does that still hold here as this is in the apps folder? I'd assume the app is setup so it could be plucked out of the tree?
There was a problem hiding this comment.
i think it still holds, because the all in one packed still requires the src tree due to the mechanism we used to build the packed runtime
There was a problem hiding this comment.
Hi @tqchen, I have updated the fix based on your recommendations
islavutin
requested review from
ZihengJiang,
areusch,
kazum,
liangfu,
masahi,
tmoreau89 and
vinx13
as code owners
|
Please resolve the merge conflicts and let’s get it merged |
|
Closing this PR since issue is addressed by #8705 |
4 participants
Minor change in config to address build issue with the latest version of Apache TVM