[PROFILING] Profiling over RPC #8885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkonolige
requested review from
ZihengJiang,
areusch,
comaniac,
jroesch,
junrushao,
kazum,
liangfu,
masahi,
merrymercy,
tmoreau89,
tqchen,
vinx13,
yzhliu and
zhiics
as code owners
added 3 commits
August 30, 2021 15:46
tkonolige
force-pushed
the
fix_remote_profiler
branch
from
432f044 to
ba49bb4
Compare
jwfromm
approved these changes
Sep 7, 2021
Contributor
jwfromm
left a comment
jwfromm
left a comment
There was a problem hiding this comment.
Some minor nitpicks but otherwise LGTM.
| self.module = _ffi_api._VirtualMachineDebug(exe.module) | ||
|
|
||
| # Make sure the constructor of the VM module is on the proper device | ||
| if device.device_type >= rpc_base.RPC_SESS_MASK: |
Contributor
There was a problem hiding this comment.
Checking device type using a >= is kind of confusing. If there isn't a better way to check can you explain why the >= works in a comment.
| while (reader.NextArrayItem()) { | ||
| calls.push_back(parse_metrics(&reader)); | ||
| } | ||
| // reader.EndArray(); |
Contributor
There was a problem hiding this comment.
should these commented out lines be removed?
Contributor
Author
There was a problem hiding this comment.
I like leaving these lines in as it makes it clear where the end of each Array/Object is.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* [PROFILING] Profiling over RPC Allow for profiling over RPC by serializing the returned report before sending it. Also remove collectors argument when profiling over rpc because it cannot be serialized. * lint * fixes * add comments
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [PROFILING] Profiling over RPC Allow for profiling over RPC by serializing the returned report before sending it. Also remove collectors argument when profiling over rpc because it cannot be serialized. * lint * fixes * add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for profiling over RPC by serializing the returned report beforesending it. Also remove collectors argument when profiling over rpc because it cannot be serialized.
@jwfromm @leandron