-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Doc] Current passes #8893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Current passes #8893
Conversation
Add a before/after example of realy pass
6867e0a to
e40f42e
Compare
|
@hogepodge @tqchen Just a gentle ping. :) Thanks! |
|
Hi @chunit-quic, I like the idea of adding simple before/after examples to passes to help users understand the passes! :) Let's wait for others' comments. |
|
Thank you @YuchenJin for like this idea. :D @hogepodge @tqchen @comaniac Just a gentle ping. It will be a big help with your advice. :) Thank you! |
|
I agree with the idea that it would be great to have examples for each pass. I'm just thinking whether we could have a more systematic way to do so instead of manually adding before/after examples to comments. For example, we could have a specific doc section showing pass examples, and we just need to write examples in Python, apply the pass, and print the result. In this way, when building documents, the Python file will be executed and the result of each pass will be generated automatically. A more specific example is like this: https://github.com/apache/tvm/blob/main/tutorials/optimize/opt_gemm.py |
|
Thank you @comaniac, it is a good suggestion! Just one more question, where the final output page could be in? Thank you. |
|
This RFC is discussing doc formalization: apache/tvm-rfcs#27 Perhaps you can chime in, or @hogepodge do you have any suggestion? |
|
I think it's useful to have the inline documentation that's automatically generated as part of the documentation system. Since the mentioned RFC is largely concerned with organization rather than content per-se, I think it's useful to write this up as an independent RFC for discussion. |
|
I've updated the documentation RFC to reference this. Once that lands, let's work up a formal proposal for inline documentation for Relay passes. |
|
Hi @hogepodge, Thank you for like this idea! Would it be fine to you? :D |

Add a before/after example of realy pass
Hi communities, I am wondering perhaps it might be good to have an example to see immediately for each (or most) relay pass in the transform document.

Therefore I create this example here.
Since the document is generated from the comments of python. I simply add more contents in its comments.
I would like to have your comments, and if it is fine I will add more before/after examples and submit request again.
@hogepodge @tqchen May I have your advices please? :D
Thank you!
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.