Skip to content

[Hexagon] Sort functions before adding to LLVM codegen #8948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kparzysz-quic wants to merge 1 commit into from
Closed

[Hexagon] Sort functions before adding to LLVM codegen #8948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/target/llvm/codegen_hexagon.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,12 @@ runtime::Module BuildHexagon(IRModule mod, Target target) {
funcs.emplace_back(f);
}

std::sort(funcs.begin(), funcs.end(), [](PrimFunc func_a, PrimFunc func_b) {
Copy link
Member

@jroesch jroesch Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is this something we should fix else where in the compiler? its probably good to add sorting/ordering for determinism.

cc @mbs-octoml @tkonolige

Copy link
Contributor

@tkonolige tkonolige Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are definitely more places in the compiler where the names should be sorted for reproducibility. I had a branch where I tried to make codegen more reproducible, but I can't find it. I remember adding sorts to llvm codegen as well as some places where IRModules were constructed.

Copy link
Contributor Author

@kparzysz-quic kparzysz-quic Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a generalized version of this PR: #8958.

std::string name_a = func_a->GetAttr<String>(tvm::attr::kGlobalSymbol).value();
std::string name_b = func_b->GetAttr<String>(tvm::attr::kGlobalSymbol).value();
return name_a < name_b;
});

cg->Init("TVMHexagonModule", tm.get(), ctx.get(), false, false, false);
for (const PrimFunc& f : funcs) {
cg->AddFunction(f);
Expand Down