Skip to content

Conversation

@leandron
Copy link
Contributor

@leandron leandron commented Sep 8, 2021

Add missing tvm.micro.project_api module file:

  • The missing init.py makes it impossible to import tvm.micro.project_api, which is indirectly done in tvmc
  • It is more evident when using tlcpack as the module is not included in the package at all

Reopening as I accidentally closed #8944.

cc @tqchen @areusch @gromero @manupa-arm @Mousius for reviews

* Add missing tvm.micro.project_api module file. The missing
  __init__.py makes it impossible to import this module with
  `import tvm.micro.project_api`.

* This uncover 30-ish linting errors, which are also fixed here.
@leandron
Copy link
Contributor Author

leandron commented Sep 8, 2021

Can someone merge this, as CI seems happy? Thanks

@manupak manupak merged commit 2e0a711 into apache:main Sep 9, 2021
@manupak
Copy link
Contributor

manupak commented Sep 9, 2021

Thanks @leandron @areusch . This is merged now.

@leandron leandron deleted the fix_proj_api_module branch September 9, 2021 13:14
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* Add missing tvm.micro.project_api module file. The missing
  __init__.py makes it impossible to import this module with
  `import tvm.micro.project_api`.

* This uncover 30-ish linting errors, which are also fixed here.
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* Add missing tvm.micro.project_api module file. The missing
  __init__.py makes it impossible to import this module with
  `import tvm.micro.project_api`.

* This uncover 30-ish linting errors, which are also fixed here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants