Skip to content

Conversation

@elvin-n
Copy link
Contributor

@elvin-n elvin-n commented Sep 10, 2021

Fixed below tests:

FAILED tests/python/relay/aot/test_crt_aot.py::test_memory_planning[8-10368-15392]
FAILED tests/python/relay/aot/test_crt_aot.py::test_memory_planning[16-10368-15424]
FAILED tests/python/relay/aot/test_crt_aot.py::test_memory_planning[256-10752-17664]

Root cause: after adding of big number x86 cpu from LLVM to topi logic and the change of the get_simd_32bit_lanes() logic to return default SIMD size to 128bit value, the tests appeared after creation of int8 AVX2 PR and which passed with previous default value started to fail after int8 AVX2 merge

The 128 is a correct value for ARM, need to change the test, not the default value in get_simd_32bit_lanes()

@elvin-n
Copy link
Contributor Author

elvin-n commented Sep 10, 2021

@Mousius and @manupa-arm could you please verify that values are correct?

@u99127
Copy link

u99127 commented Sep 10, 2021

128 is correct for Advanced SIMD i.e. the SIMD unit in Cortex-A CPUs.

@areusch
Copy link
Contributor

areusch commented Sep 10, 2021

@elvin-n do you mind tagging the PRs you mentioned above here?

@elvin-n
Copy link
Contributor Author

elvin-n commented Sep 10, 2021

patch was integrated into PR8980, close this

@elvin-n elvin-n closed this Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants