Move external codegen test helpers into utils #9008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so they can be re-used as part of other tests which don't extend test_external_codegen.py I've identified that `test_json_runtime.py` and `test_pass_partition_graph.py` use a very similar but slightly different variant of these functions for future iterations.
Mousius
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
This is so they can be re-used as part of other tests which don't extend test_external_codegen.py I've identified that `test_json_runtime.py` and `test_pass_partition_graph.py` use a very similar but slightly different variant of these functions for future iterations.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This is so they can be re-used as part of other tests which don't extend test_external_codegen.py I've identified that `test_json_runtime.py` and `test_pass_partition_graph.py` use a very similar but slightly different variant of these functions for future iterations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Spun out of #8423)
This is so they can be re-used as part of other tests which don't extend test_external_codegen.py
I've identified that
test_json_runtime.pyandtest_pass_partition_graph.pyuse a very similar but slightly different variant of these functions for future iterations on this theme.