Skip to content

Conversation

@mehrdadh
Copy link
Member

This PR:

@mehrdadh mehrdadh force-pushed the fix_zephyr_tune_test_hw branch from 0679917 to 2da1a7a Compare September 15, 2021 15:26
@mehrdadh
Copy link
Member Author

cc @leandron @areusch for possible review.

Copy link
Contributor

@huajsj huajsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mehrdadh.


$(BUILD_DIR)/crt/lib%.a: $(glob crt/src/runtime/%/*.c)
${QUIET}cd crt && $(MAKE) \
${QUIET}cd crt && $(MAKE) -s \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need this and verbose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, otherwise you get messages like make[1]: Entering directory '/tmp/tmptwf17bxw/generated-project/crt'

@mehrdadh mehrdadh force-pushed the fix_zephyr_tune_test_hw branch 2 times, most recently from 2b31a1f to 84d738c Compare September 16, 2021 19:14
@mehrdadh mehrdadh force-pushed the fix_zephyr_tune_test_hw branch from 84d738c to c5e8ee0 Compare September 16, 2021 19:16
Copy link
Contributor

@huajsj huajsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, just couple comments. Thanks @mehrdadh.


# measure_option = tvm.autotvm.measure_option(builder=builder, runner=runner)
#
# measure_option = tvm.autotvm.measure_option(builder=builder, runner=runner)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one space?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the tutorial format. Picked it up from other tutorials.

@areusch areusch merged commit 9100a3c into apache:main Sep 17, 2021
@mehrdadh mehrdadh deleted the fix_zephyr_tune_test_hw branch September 17, 2021 15:58
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* fix test and cleanup

* fix tutorial doc

* fix verbose for tutorial

* fix tune check

* address comments

* address comments
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* fix test and cleanup

* fix tutorial doc

* fix verbose for tutorial

* fix tune check

* address comments

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants