-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[microTVM][autoTVM] Follow up fixes to #9003 #9018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d0849cf to
0679917
Compare
0679917 to
2da1a7a
Compare
huajsj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mehrdadh.
|
|
||
| $(BUILD_DIR)/crt/lib%.a: $(glob crt/src/runtime/%/*.c) | ||
| ${QUIET}cd crt && $(MAKE) \ | ||
| ${QUIET}cd crt && $(MAKE) -s \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need this and verbose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, otherwise you get messages like make[1]: Entering directory '/tmp/tmptwf17bxw/generated-project/crt'
2b31a1f to
84d738c
Compare
84d738c to
c5e8ee0
Compare
huajsj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM, just couple comments. Thanks @mehrdadh.
|
|
||
| # measure_option = tvm.autotvm.measure_option(builder=builder, runner=runner) | ||
| # | ||
| # measure_option = tvm.autotvm.measure_option(builder=builder, runner=runner) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the tutorial format. Picked it up from other tutorials.
* fix test and cleanup * fix tutorial doc * fix verbose for tutorial * fix tune check * address comments * address comments
* fix test and cleanup * fix tutorial doc * fix verbose for tutorial * fix tune check * address comments * address comments
This PR: