Skip to content

Conversation

@zxybazh
Copy link
Member

@zxybazh zxybazh commented Sep 20, 2021

This PR is part of the stage M3a of the meta schedule project (#8473).

The architecture is re-designed by Junru and Xiyou. TuneContext contains all the resources, i.e., related classes for a single tuning task. The class can be accessed in both python side and c++ side. No function is designated inside.

More classes would be added to TuneContext as we proceed with the upstreaming.

Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>

@zxybazh zxybazh force-pushed the tensorir-infra/upstream/2021-09-20/tune-context branch from 6099add to e99bb33 Compare September 20, 2021 21:36
@comaniac
Copy link
Contributor

Hey you probably need to rebase after #9044 is merged?

@zxybazh
Copy link
Member Author

zxybazh commented Sep 20, 2021

Hey you probably need to rebase after #9044 is merged?

Already rebaed : )

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@junrushao
Copy link
Member

Otherwise looks good to me! Thanks @zxybazh

zxybazh and others added 8 commits September 20, 2021 16:23
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@zxybazh zxybazh force-pushed the tensorir-infra/upstream/2021-09-20/tune-context branch from cef26b3 to 9bc31d3 Compare September 20, 2021 23:24
@zxybazh
Copy link
Member Author

zxybazh commented Sep 22, 2021

Please merge the PR if no further issues, thanks!

@junrushao junrushao merged commit cd15b79 into apache:main Sep 22, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
* Add TuneContext class.

Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>

* Add tune context test.

* Add meta_schedule to cmake.

* Add type.

* Rebase.

* Disable MyPy for ethosu.

* Add new line.

* Remove duplicate line.

* Minor fix.

* Add comments.

Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* Add TuneContext class.

Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>

* Add tune context test.

* Add meta_schedule to cmake.

* Add type.

* Rebase.

* Disable MyPy for ethosu.

* Add new line.

* Remove duplicate line.

* Minor fix.

* Add comments.

Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@junrushao junrushao changed the title [Meta Schedule][M3a] TuneContext [MetaSchedule][M3a] TuneContext Jan 26, 2022

echo "Checking MyPy Type defs in the tvm.relay.backend.contrib.ethosu package."
mypy --check-untyped-defs python/tvm/relay/backend/contrib/ethosu/
#TODO(@mikepapadim): This is failing atm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue if things like this happens and possibly ping codeowners please, we were not aware that any of the checked in code was not tested until recently.

cc : @mikepapadim @junrushao1994

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I thought we did, but it turned out haven't...Please make sure to report in time :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh actually we reported in this thread: #9050. definitely should submit it as a separate PR though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea but that PR was closed saying not needed. Thus, I was under the impression that was never merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants