Fix building with llvm 13 #9148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::string getName(ID Id, ArrayRef<Type *> Tys);` was removed in llvm/llvm-project@bb8ce25 and is contained in `llvmorg-13.0.0-rc1` and onward.
cloudhan
requested review from
ZihengJiang,
junrushao,
kparzysz-quic,
masahi,
tqchen and
vinx13
as code owners
Author
|
@junrushao1994 Please take a quick look at this simple change. |
leandron
reviewed
Sep 29, 2021
Contributor
leandron
left a comment
leandron
left a comment
There was a problem hiding this comment.
Looks like a simple change. I see there is a conflict, which will probably go away once you rebase and update your PR.
Apart from that, I'm curious on whether we could also improve https://github.com/apache/tvm/blob/main/docker/install/ubuntu1804_install_llvm.sh to, perhaps, remove LLVM-9 and LLVM-10, to include 13, as CI runs really with LLVM-11?
(cc @areusch)
Contributor
|
This was already fixed as a part of #9138. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::string getName(ID Id, ArrayRef<Type *> Tys);was removed in llvm/llvm-project@bb8ce25 and is contained inllvmorg-13.0.0-rc1and onward.