[ETHOSN] Match config for is-supported with compilation target #9160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-blonk
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
manupak,
mbaret,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
manupak
approved these changes
Sep 30, 2021
Contributor
manupak
left a comment
manupak
left a comment
There was a problem hiding this comment.
LGTM modulo a nit.
A question : how does the code work w/o this change ? (I guess there should be accompanied docker change with versions)
leo-blonk
force-pushed
the
issupported
branch
2 times, most recently
from
b3a01a9 to
06b487f
Compare
leo-blonk
force-pushed
the
issupported
branch
from
c2c80a0 to
0dde9b8
Compare
leo-blonk
force-pushed
the
issupported
branch
from
67cfbca to
88bf112
Compare
The Ethos-N variant configuration for the is-supported functionality is now the same as the variant configuration for the actual compilation
4 tasks
manupak
reviewed
Oct 22, 2021
| static std::pair<std::vector<uint32_t>, std::vector<uint32_t>> GetInputOutputOrder( | ||
| NetworkWithIDs network, const std::unique_ptr<sl::CompiledNetwork>& compiled_network); | ||
|
|
||
| static std::unique_ptr<sl::SupportQueries> m_Queries; |
| : AttrsWithDefaultValues<EthosnCompilerConfig>(); | ||
| auto m_Queries = sl::SupportQueries(sl::GetFwAndHwCapabilities( | ||
| sl::EthosNVariantFromString(cfg.value()->variant.c_str()), cfg.value()->sram_size_bytes)); | ||
| std::unique_ptr<sl::SupportQueries> EthosnCompiler::m_Queries; |
Contributor
There was a problem hiding this comment.
nit : Do we need this line ?
Contributor
Author
|
Thanks Manupa. I expect to issue the following PR in the next days and I will take care of the two issues there, if that is OK with you. |
Contributor
|
This is merged now!. Thanks @Leo-arm. |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…e#9160) The Ethos-N variant configuration for the is-supported functionality is now the same as the variant configuration for the actual compilation
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…e#9160) The Ethos-N variant configuration for the is-supported functionality is now the same as the variant configuration for the actual compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ethos-N variant configuration for the is-supported functionality is now
the same as the variant configuration for the actual compilation