[CMSIS-NN] Initial operator support for Mul #9163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
manupak,
mbaret,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
manupak
requested changes
Sep 30, 2021
Contributor
manupak
left a comment
manupak
left a comment
There was a problem hiding this comment.
Broadly looks good : one nit and a question.
Mousius
force-pushed
the
cmsis-mul-operator
branch
from
cf54890 to
762d7e8
Compare
manupak
approved these changes
Sep 30, 2021
Member
Author
|
@manupa-arm no need, just did it: #9167 |
This is largely as it says on the tin, it adds Mul support to CMSIS-NN
Mousius
force-pushed
the
cmsis-mul-operator
branch
from
762d7e8 to
ab20bbc
Compare
Contributor
|
Thanks @Mousius @ashutoshparkhi. |
areusch
reviewed
Oct 4, 2021
| from tvm import relay | ||
|
|
||
|
|
||
| def skip_if_no_reference_system(func): |
Contributor
There was a problem hiding this comment.
should we improve this a bit and make it less brittle? it seems like if we ever use this from a different test (e.g. TOPI tests run on GPU) we may need to broaden it a bit. i'm not sure Corstone300 provides a good way to detect it from TVM--but perhaps you guys know better? we could just add a pytest mark and flag --enable-corstone300-tests and add the flag to the relevant tests/scripts/task_*.sh file.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
This is largely as it says on the tin, it adds Mul support to CMSIS-NN
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This is largely as it says on the tin, it adds Mul support to CMSIS-NN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely as it says on the tin, it adds Mul support to CMSIS-NN