Support quantised RSQRT operator in TFLite #9165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ophirfrish
requested review from
Huyuwei,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
merrymercy,
siju-samuel,
srkreddy1238,
tqchen and
yzhliu
as code owners
leandron
approved these changes
Sep 30, 2021
Contributor
leandron
left a comment
leandron
left a comment
There was a problem hiding this comment.
LGTM. As @ophirfrish mentioned. This PR will open the opportunity for us to add other quantised operator support, in separate PRs, with appropriate testing, etc.
We’ll soon create a tracking issue for this list of operators.
The commit tests _convert_unary_elemwise function for the quantised and non quantized tensor for the RSQRT op. Other operators will be tested in future (separated )commits.
13 tasks
Contributor
|
As all the tests are passing here, and the issue is sitting here for a few days, I'll merge it and we can take any required changes as follow-up patches. For the potential operators that can be implemented in future, benefiting from this PR, we raised #9187. Thanks @ophirfrish! |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
The commit tests _convert_unary_elemwise function for the quantised and non quantized tensor for the RSQRT op. Other operators will be tested in future (separated )commits.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
The commit tests _convert_unary_elemwise function for the quantised and non quantized tensor for the RSQRT op. Other operators will be tested in future (separated )commits.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit tests _convert_unary_elemwise function for the quantized and
non quantized tensor for the RSQRT op.
Other operators will be tested in future (separated) commits.
cc @areusch @leandron @gromero @Mousius for reviews