[Contrib][ONNX] Handle removal of onnx.utils.polish_model #9178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
requested review from
areusch,
comaniac,
jroesch,
junrushao,
leandron,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
Onnx 1.9 removed optimizers from the core repository (see discussion in onnx/onnx#2834), including onnx.utils.polish_model, breaking RelayToONNXConverter. This PR add onnxoptimizer.optimize as a fallback method if onnx.utils.polish_model is unavailable. Also updates tutorials/documentation to recommend installing onnxoptimizer when installing onnx, because the current PyPI version of onnx is above version 1.9.
Lunderberg
force-pushed
the
onnx_1.9_compatibility
branch
from
18cbaec to
d1c58a6
Compare
masahi
approved these changes
Oct 2, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
Onnx 1.9 removed optimizers from the core repository (see discussion in onnx/onnx#2834), including onnx.utils.polish_model, breaking RelayToONNXConverter. This PR add onnxoptimizer.optimize as a fallback method if onnx.utils.polish_model is unavailable. Also updates tutorials/documentation to recommend installing onnxoptimizer when installing onnx, because the current PyPI version of onnx is above version 1.9.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Onnx 1.9 removed optimizers from the core repository (see discussion in onnx/onnx#2834), including onnx.utils.polish_model, breaking RelayToONNXConverter. This PR add onnxoptimizer.optimize as a fallback method if onnx.utils.polish_model is unavailable. Also updates tutorials/documentation to recommend installing onnxoptimizer when installing onnx, because the current PyPI version of onnx is above version 1.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onnx 1.9 removed optimizers from the core repository (see discussion
in onnx/onnx#2834), including
onnx.utils.polish_model, breaking RelayToONNXConverter. This PR add
onnxoptimizer.optimize as a fallback method if onnx.utils.polish_model
is unavailable.
Also updates tutorials/documentation to recommend installing
onnxoptimizer when installing onnx, because the current PyPI version
of onnx is above version 1.9.