[UnitTests][CMSISNN] Mark CMSISNN with skipif they are missing libraries #9179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Show test as skipped, rather than failing test.
Lunderberg
force-pushed
the
test_cmsisnn_pytest_skipif
branch
from
97976f9 to
6631264
Compare
Contributor
|
Should we do it similar to |
Contributor
Author
|
We can, yes. My initial goal was to avoid adding too many utility functions that are only used for one or two tests, but I can see how having separate ways of doing the same thing would lead to growing pains and confusion down the line. |
areusch
approved these changes
Oct 5, 2021
Contributor
|
Thanks @Lunderberg :) |
Mousius
added a commit
to Mousius/tvm
that referenced
this pull request
Oct 5, 2021
apache#9179 and apache#9167 both landed at the same time which resulted in new tests without the skipping.
masahi
pushed a commit
that referenced
this pull request
Oct 6, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…ies (apache#9179) * [UnitTests][CMSISNN] Mark CMSISNN with skipif they are missing libraries Show test as skipped, rather than failing test. * Added tvm.testing.requires_cmsisnn
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…e#9200) apache#9179 and apache#9167 both landed at the same time which resulted in new tests without the skipping.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…ies (apache#9179) * [UnitTests][CMSISNN] Mark CMSISNN with skipif they are missing libraries Show test as skipped, rather than failing test. * Added tvm.testing.requires_cmsisnn
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…e#9200) apache#9179 and apache#9167 both landed at the same time which resulted in new tests without the skipping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show test as skipped, rather than failing test.