[Test] Fix flaky LocalRunner test due to restrictive timeout #9181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
requested review from
areusch,
comaniac,
jroesch,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
zxybazh
approved these changes
Oct 3, 2021
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for fixing the time out.
Hzfengsy
approved these changes
Oct 3, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flakiness introduced by #9153 hasn't been exposed on our CI, but can be reproduced very frequently in my local machine. The root of the issue is that our timeout setting in LocalRunner in this particular unittest is too small (1s). Given it's a LocalRunner which always exist, I increased the timeout to 30s by default.
CC: @shingjan @vinx13 @zxybazh