[cpptest] Get the full path to gtest_main library #9201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gtest framework requires two libraries: gtest and gtest_main. The former is found via "find_library", which returns the full path to it. The latter is only added to target_link_libraries as "gtest_main". Adding "gtest_main" to target_link_libraries causes cmake to emit -lgtest_main, but the path to it is not provided (there is no -L flag for it), and the link step can fail. As a fix, use find_library to get the full path to gtest_main as well.
kparzysz-quic
requested review from
a team,
areusch,
comaniac,
jroesch,
junrushao and
tqchen
as code owners
Contributor
|
It seems like this problem could be fixed by using |
Contributor
Author
I didn't know about it. I will have the changes ready soon. |
Contributor
Author
|
Replaced by #9208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gtest framework requires two libraries:
gtestandgtest_main. The former is found viafind_library, which returns the full path to it. The latter is only added to target_link_libraries asgtest_main. Addinggtest_mainto target_link_libraries causes cmake to emit-lgtest_main, but the path to it is not provided (there is no-Lflag for it), and the link step can fail.As a fix, use
find_libraryto get the full path togtest_mainas well.