[UnitTest] Removed vulkan from CI run of task_python_topi.sh #9219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulkan unit tests were enabled with apache#9093, but were only intended to run tests/python/unittest/test_target_codegen_vulkan.py. Since task_python_topi.sh did not explicitly specify `TVM_TEST_TARGETS`, it defaulted to `tvm.testing.utils.DEFAULT_TEST_TARGETS`, which includes the vulkan runtime. This commit adds an explicit specification of `TVM_TEST_TARGETS` for the topi unit tests, matching the targets enabled in the CI GPU build, but excluding vulkan.
Lunderberg
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
Contributor
Author
masahi
approved these changes
Oct 7, 2021
masahi
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
…9219) Vulkan unit tests were enabled with apache#9093, but were only intended to run tests/python/unittest/test_target_codegen_vulkan.py. Since task_python_topi.sh did not explicitly specify `TVM_TEST_TARGETS`, it defaulted to `tvm.testing.utils.DEFAULT_TEST_TARGETS`, which includes the vulkan runtime. This commit adds an explicit specification of `TVM_TEST_TARGETS` for the topi unit tests, matching the targets enabled in the CI GPU build, but excluding vulkan.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…9219) Vulkan unit tests were enabled with apache#9093, but were only intended to run tests/python/unittest/test_target_codegen_vulkan.py. Since task_python_topi.sh did not explicitly specify `TVM_TEST_TARGETS`, it defaulted to `tvm.testing.utils.DEFAULT_TEST_TARGETS`, which includes the vulkan runtime. This commit adds an explicit specification of `TVM_TEST_TARGETS` for the topi unit tests, matching the targets enabled in the CI GPU build, but excluding vulkan.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…9219) Vulkan unit tests were enabled with apache#9093, but were only intended to run tests/python/unittest/test_target_codegen_vulkan.py. Since task_python_topi.sh did not explicitly specify `TVM_TEST_TARGETS`, it defaulted to `tvm.testing.utils.DEFAULT_TEST_TARGETS`, which includes the vulkan runtime. This commit adds an explicit specification of `TVM_TEST_TARGETS` for the topi unit tests, matching the targets enabled in the CI GPU build, but excluding vulkan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulkan unit tests were enabled with #9093, but were only intended to run tests/python/unittest/test_target_codegen_vulkan.py. Since task_python_topi.sh did not explicitly specify
TVM_TEST_TARGETS, it defaulted totvm.testing.utils.DEFAULT_TEST_TARGETS, which includes the vulkan runtime.