[Relay] Gather op dynamic input support #9240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
requested review from
Huyuwei,
Laurawly,
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
jcf94,
jroesch,
junrushao,
jwfromm,
kevinthesun,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Contributor
|
Thanks @masahi |
masahi
added a commit
to Laurawly/tvm-1
that referenced
this pull request
Oct 14, 2021
* support gather op dynamic input * fix shape func and add test * remove constness check * fix shape func output rank * restore check Co-authored-by: masa <masa@pop-os.localdomain>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* support gather op dynamic input * fix shape func and add test * remove constness check * fix shape func output rank * restore check Co-authored-by: masa <masa@pop-os.localdomain>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* support gather op dynamic input * fix shape func and add test * remove constness check * fix shape func output rank * restore check Co-authored-by: masa <masa@pop-os.localdomain>
apivovarov
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 12, 2022
* support gather op dynamic input * fix shape func and add test * remove constness check * fix shape func output rank * restore check Co-authored-by: masa <masa@pop-os.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using dynamic inputs shape with
gatherop results in segfault attvm/src/relay/op/tensor/transform.cc
Line 3264 in 7deebc6
gatheris such a common op, it didn't support dynamic shapes. This PR fixed that. Thanks @interesaaat for reporting the bug.please review @comaniac @mbrookhart @AndrewZhaoLuo