[Keras] Support return_sequences in LSTM#9303
Merged
vinx13 merged 1 commit intoapache:mainfrom Oct 19, 2021
Merged
Conversation
apivovarov
requested review from
Huyuwei,
areusch,
comaniac,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
merrymercy,
siju-samuel,
srkreddy1238,
tqchen and
yzhliu
as code owners
apivovarov
force-pushed
the
lstm
branch
2 times, most recently
from
f1b67f9 to
857ca0b
Compare
Contributor
Author
|
@Huyuwei @mbrookhart @kazum @yongwww Guys, can you help to review this PR? |
Mousius
approved these changes
Oct 19, 2021
vinx13
approved these changes
Oct 19, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
return_sequencesbool param for Keras LSTM layer.By default the param is False - LSTM returns only the last h output
If
return_sequences is Truethen ALL h outputs should be returned. The outputs should be concatenated along axis 1.I also added dedicated test for LSTM. Input shape increased to test
return_sequences is Truecase.return_sequences = Trueis needed if your model has two or more LSTM layers. By Default LSTM layer takes 3D tensor and returns 2D tensor. To connect two LSTM layers together the first layers should return 3D tensor. It can be achieved ifreturn_sequences paramset toTrue.Understanding LSTM Networks
Related discussion https://discuss.tvm.apache.org/t/keras-lstm-return-sequences-parameter-not-supported/11239