Skip to content

[Fixbug] Report duplicated param names of relay function when bind params #9350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junrushao merged 3 commits into from
Oct 24, 2021
Merged

[Fixbug] Report duplicated param names of relay function when bind params #9350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66d5980
[Fixbug] Report duplicated param names of relay function when bind pa…
yaoyaoding Oct 22, 2021
b41957c
add test
yaoyaoding Oct 23, 2021
85bfdde
lint
yaoyaoding Oct 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/relay/backend/utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ inline relay::Function BindParamsByName(
for (auto arg : func->params) {
const auto& name = arg->name_hint();
if (name_dict.count(name)) {
repeat_var.insert(arg);
repeat_var.insert(name_dict[name]);
} else {
name_dict[name] = arg;
}
Expand Down
13 changes: 13 additions & 0 deletions tests/python/relay/test_ir_bind.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@
# specific language governing permissions and limitations
# under the License.
""" test bind function."""
import pytest
import tvm
from tvm import te
from tvm import relay
from tvm import TVMError


def test_bind_params():
Expand All @@ -34,5 +36,16 @@ def test_bind_params():
assert tvm.ir.structural_equal(zbinded, zexpected)


def test_bind_duplicated_params():
a = relay.var("a", shape=(1,))
aa = relay.var("a", shape=(1,))
s = a + aa
func = relay.Function([a, aa], s)

with pytest.raises(TVMError):
relay.build_module.bind_params_by_name(func, {"a": [1.0]})


if __name__ == "__main__":
test_bind_params()
test_bind_duplicated_params()