Skip to content

Conversation

@NicolaLancellotti
Copy link
Contributor

@NicolaLancellotti NicolaLancellotti commented Nov 4, 2021

This pr add a rolling buffer scheduling primitive.
The pr is based on @mbaret's pr #7925 , and it differs in that the InjectRollingBuffer pass has been rewritten in C++, (originally it was written in Python).
Also since the original pr was written, the TIR changed a bit, and as a consequence, some code has been moved between the visitors' methods.

@manupak
Copy link
Contributor

manupak commented Nov 5, 2021

This is based on #7925 but in C++.
cc : @junrushao1994 @jcf94 @Hzfengsy it would be great if you guys can have another look. TIA

@NicolaLancellotti NicolaLancellotti force-pushed the passes/rolling_buffer branch 2 times, most recently from e30c09c to 25f32f3 Compare November 9, 2021 17:47
NicolaLancellotti and others added 3 commits November 10, 2021 10:43
Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126
Change-Id: Ic148264239eac7df7d976a6a3e15236935232792
@NicolaLancellotti
Copy link
Contributor Author

I fixed the CI issues.

@manupak
Copy link
Contributor

manupak commented Nov 16, 2021

@mbaret -- Would you be able to have a look and see if its matching the original approved implementation so that we could get this in ? Possibly follow up if and when concerns arises later ?

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's similar logic with #7925 and re-implemented in C++. Thanks!

Copy link
Member

@Hzfengsy Hzfengsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hzfengsy Hzfengsy merged commit 9454aa4 into apache:main Nov 18, 2021
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
* Add a 'rolling_buffer' scheduling primitive

Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>

* Fix lint problems

Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126

* Remove designated initializers

Change-Id: Ic148264239eac7df7d976a6a3e15236935232792

Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
* Add a 'rolling_buffer' scheduling primitive

Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>

* Fix lint problems

Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126

* Remove designated initializers

Change-Id: Ic148264239eac7df7d976a6a3e15236935232792

Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
* Add a 'rolling_buffer' scheduling primitive

Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>

* Fix lint problems

Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126

* Remove designated initializers

Change-Id: Ic148264239eac7df7d976a6a3e15236935232792

Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
* Add a 'rolling_buffer' scheduling primitive

Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>

* Fix lint problems

Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126

* Remove designated initializers

Change-Id: Ic148264239eac7df7d976a6a3e15236935232792

Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
* Add a 'rolling_buffer' scheduling primitive

Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>

* Fix lint problems

Change-Id: I5e27a66105fccca84327e41b4c68836ac2515126

* Remove designated initializers

Change-Id: Ic148264239eac7df7d976a6a3e15236935232792

Co-authored-by: Matthew Barrett <Matthew.Barrett@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants