[6/10] Code generation for fully connected layer via CMSIS-NN #9456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asparkhi
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
leandron,
manupak,
mbaret,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Contributor
Author
|
cc: @Mousius @manupa-arm @leandron @areusch for code reviews. |
Change-Id: I67f65e69dfa2c6d31c2ea928d92a827df80bc51a
manupak
requested changes
Dec 2, 2021
Contributor
manupak
left a comment
manupak
left a comment
There was a problem hiding this comment.
Broadly looks good! Few stylistic comments!
| scalar_args = tvm::runtime::Concat(scalar_args, cmsisnn_filter_shape); | ||
| scalar_args = tvm::runtime::Concat(scalar_args, bias_shape); | ||
| scalar_args = tvm::runtime::Concat(scalar_args, cmsisnn_output_shape); | ||
| call_ext_args = tvm::runtime::Concat(call_ext_args, scalar_args); |
Contributor
There was a problem hiding this comment.
nit : Would it be possible to keep the definitions of sub-catergories that get concatenated closer to here ? So it is easy to follow ?
Contributor
Author
There was a problem hiding this comment.
I didn't get this. Which ones should be close together and are not?
Contributor
There was a problem hiding this comment.
e.g.
Array<PrimExpr> cmsisnn_input_shape{input_shape[0], 1, 1, input_shape[1]};
scalar_args = tvm::runtime::Concat(scalar_args, cmsisnn_input_shape);
Array<PrimExpr> cmsisnn_filter_shape{in_channels, 1, 1, out_channels};
scalar_args = tvm::runtime::Concat(scalar_args, cmsisnn_filter_shape);
Contributor
Author
There was a problem hiding this comment.
I see what you mean
Contributor
Author
There was a problem hiding this comment.
Can't do because of a cross dependency in this case 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for fully connected layer via CMSIS-NN.
Here is the tracking issue: #8646